[Webkit-unassigned] [Bug 7476] WebKit does not handle invalid MIME types for SVG

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=7476





------- Comment #8 from macdome at opendarwin.org  2006-08-14 23:36 PDT -------
(In reply to comment #7)
> (From update of attachment 10004 [edit])
> Looks generally fine, but this won't compile:
> 
> +    return (mimeType == "image/svg+xml");
> +         || mimeType == "image/svg-xml" // invalid, Adobe SVG Viewer
> compatibility
> +         || mimeType == "image/xml+svg"); // invalid, Adobe SVG Viewer
> compatibility
> 
> Also, we should have some tests of these MIME types -- we have http tests that
> can test this sort of thing.
> 
> -            d->m_decoder->setEncodingName(d->m_encoding.latin1(),
> -                d->m_haveEncoding ? Decoder::UserChosenEncoding :
> Decoder::EncodingFromHTTPHeader);
> +            d->m_decoder->setEncodingName(d->m_encoding.latin1(),
> d->m_haveEncoding ? Decoder::UserChosenEncoding :
> Decoder::EncodingFromHTTPHeader);
> 
> The above does not look like an improvement. The old formatting looks better.
> 

OK.

What you listed does actually compile with GCC.  Maybe it won't with other
compilers however.

Eventually I'll find some time to make a test case or two and re-post.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.