[Webkit-unassigned] [Bug 10383] New: KRenderingDeviceContextQuartz must DIE

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10383

           Summary: KRenderingDeviceContextQuartz must DIE
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: SVGHitList
          Severity: normal
          Priority: P2
         Component: Web Inspector
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: macdome at opendarwin.org


KRenderingGraphicsContextQuartz must DIE

It pains me every time I read this code:

    KRenderingDeviceContext* context = device->currentContext();
    bool shouldPopContext = false;
    if (context)
        paintInfo.p->save();
    else {
        // Need to set up KCanvas rendering if it hasn't already been done.
        context = paintInfo.p->createRenderingDeviceContext();
        device->pushContext(context);
        shouldPopContext = true;
    }

.
.
.

    // restore drawing state
    if (!shouldPopContext)
        paintInfo.p->restore();
    else {
        device->popContext();
        delete context;
    }

This is totally unnecessary.  GraphicsContext should be able to do all of this
for us.  GraphicsContext needs to be extended and KRenderingDeviceContextQuartz
(and the associated KRenderingDevice containing a stack of these buggers) must
die!

We can't ship SVG with this monstrosity.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.