[Webkit-unassigned] [Bug 6010] SVGLoad event is not supported

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6010


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9995|review?                     |review+
               Flag|                            |




------- Comment #20 from darin at apple.com  2006-08-12 18:16 PDT -------
(From update of attachment 9995)
Looks good. r=me

Code like this:

-        ExceptionCode ec;
-        RefPtr<Event> ev = m_doc->createEvent("HTMLEvents", ec);
-        ev->initEvent(readystatechangeEvent, true, true);
+        RefPtr<Event> ev = new Event(readystatechangeEvent, true, true);
         m_onReadyStateChangeListener->handleEvent(ev.get(), true);

can just be written as:
         m_onReadyStateChangeListener->handleEvent(new
Event(readystatechangeEvent, true, true), true);

One of the nice things about PassRefPtr is that it enables that idiom, and it's
actually more efficient too. There's no need for the get() in any case, since
you can pass a RefPtr to a PassRefPtr without it. If you want to be more
optimal you could use release() there instead of get().


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.