[Webkit-unassigned] [Bug 5358] The outermost <svg> element needs to clip itself

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=5358





------- Comment #17 from darin at apple.com  2006-08-12 18:11 PDT -------
(From update of attachment 9976)
Exciting to get this fixed!

I can't tell why this patch adds a concatCTM function to GraphicsContext. The
rest of the patch doesn't seem to use that. Is that an independent change?

The removal of mapFromVisual and mapToVisual looks great, but it also seems
independent from the rest of the patch.

The substance of the patch, in RenderSVGContainer and CSSStyleSelector, seems
pretty good.

The part in adjustRenderStyle seems a little bit "literal-minded" and I also
think a switch statement would be better than cascaded ifs -- for one thing
we'd get a warning if we ever added new overflow values. Also, we might need to
do something with our special overflow values like "overlay" and a switch
statement could make that clearer.

I'm not entirely sure that the rule in requiresLayer is correct. I'd like Hyatt
to review that.

Seems like this patch should add an addClip function that takes a FloatRect. I
don't see a reason to land this with a FIXME -- that would be a straightforward
change.

I'd like to see the unrelated cleanup landed first -- I'm tempted to just do it
myself soon.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.