[Webkit-unassigned] [Bug 10343] New: Windows portability fixes

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10343

           Summary: Windows portability fixes
           Product: WebKit
           Version: 420+ (nightly)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: kkowalczyk at gmail.com


1. CSSValueKeywords.in has empty lines which, they end up in
CSSValueKeywords.gperf because makevalues script doesn't filter them out, this
makes gperf fail and the build will fail because CSSValueKeywords.* are not
properly generated

Fix is to remove empty lines (as in attached patch) or fix makevalues script to
filter them out.

2. ENCODING_PREFIX in build-generated-files.sh needs to be defined as "\" \"",
otherwise it'll end up being nothing in DerivedSources.make and the followig
line will fail:

CharsetData.cpp : platform/make-charset-table.pl platform/character-sets.txt
$(ENCODINGS_FILE)
        perl $^ $(ENCODINGS_PREFIX) > $@

A comment about that is in make-generated-sources.sh (but it's probably not
used anymore). In general, this is very fragile so even a better fix would be
good (one that adds some diagnostics to scripts - diagnosing build problems due
to one of those scripts that auto-generate files failing isn't easy).

Also, it would be nice if VS build would stop if pre-build event fails, because
going on is usually pointless since it'll stop at some much later point with
obscure error. Unfortuantely, I don't know the required VS magic (if one
exists).


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.