[Webkit-unassigned] [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10230


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9964|review?                     |review+
               Flag|                            |




------- Comment #24 from darin at apple.com  2006-08-10 16:55 PDT -------
(From update of attachment 9964)
This looks fine. But there are more-efficient alternatives:

For example, you could make this:

    static void addString(HashSet<StringImpl*, CaseInsensitiveHash>& set, const
char* string)
    {
        StringImpl* s = new StringImpl(string);
        s->ref();
        add(set, s);
    }

Then you wouldn't need local variables at all:

    #define SVGFEATURE(feature) addString(svgFeatures, #feature);

And in fact, invoking this is simple enough that you don't even need to use a
macro! And you don't need SVGFEATURE2.
Also, isSVG10Feature and isSVG11Feature should both be marked static.

Feel free to land what you have, or please post a new patch based on my
suggestions.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.