[Webkit-unassigned] [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10230


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9912|review?                     |review+
               Flag|                            |




------- Comment #17 from darin at apple.com  2006-08-08 08:31 PDT -------
(From update of attachment 9912)
Ideally, I'd like to see the test cover some poorly-formed feature strings too,
and test the case insensitivity more directly. It's good as-is, but could be
even better.

+#if SVG_SUPPORT

Should use #ifdef SVG_SUPPORT as in the upcoming patch to fix compilation
without SVG while using -Wundef.

You don't really need the initialized boolean. Can just check is the HashSet is
empty using isEmpty.

But those are nitpicks, this looks fine now.

r=me


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.