[Webkit-unassigned] [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation)

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Sat Aug 5 14:47:09 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10230


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9894|review?                     |review+
               Flag|                            |




------- Comment #10 from macdome at opendarwin.org  2006-08-05 14:47 PDT -------
(From update of attachment 9894)
This looks fabulous.

two comments:

1. this comment is backwards:
+// TODO: features need to be commented out when we implement them

things should be "uncommented" once we implement them.

also I would probably have used FALSE and true or some more-easily
distinguisable pair of vaues in the test case.

Looks great!
r=me.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list