[Webkit-unassigned] [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation)

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=10230





------- Comment #6 from macdome at opendarwin.org  2006-08-04 10:20 PDT -------
(From update of attachment 9871)
I believe darin was refering to using HashSet<StringImpl, CaseInsensitiveHash>
instead of HashSet<String>

That would avoid any need to upper/lower the strings.

The rest of hasFeature could be converted to using a set if you really felt
adventurous.

Unless this changes already existing layout tests, a test case is needed.

Infact, ideally only features that we currently support should be present in
that set.  The ideal test case would check hasFeature and isSupported for every
possible value, and print out the value name and YES/NO.  Then when we add
features to WebKit we would turn them on (uncomment them) in
DOMImplementation.cpp, and that test case would be affected.

I'll leave this for darin/mjs to have a final opinion on.  I think the code is
pretty much ready to land, but it would be good to have a test case, and good
to only "turn on" hasFeature support for features we actually have fully (or
mostly) implemented.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.