[Webkit-unassigned] [Bug 10230] SVGDOMImplementation should die (and be rolled into DOMImplementation)

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu Aug 3 13:49:51 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=10230


darin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9856|review?                     |review-
               Flag|                            |




------- Comment #2 from darin at apple.com  2006-08-03 13:49 PDT -------
(From update of attachment 9856)
Instead of upper.startsWith("HTTP://WWW.W3.ORG/TR/SVG11/FEATURE#") I'd like to
see feature.startsWith(xxx, false).

The svgFeatureSet set should be a case insensitive set intsead of being a case
sensitive HashSet.

But if we're going to use all uppercase it should not include "dom.svg.ALL" in
mixed case!

I'd prefer not to use "upper()" at all.

Also, don't use braces around single lines in this code:

+    if (namespaceURI == SVGNames::svgNamespaceURI) {
+        doc = new SVGDocument(this, 0);
+    }


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list