[Webkit-unassigned] [Bug 8615] Parser should re-parent nodes when their parents are removed from the DOM during parsing

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Apr 26 18:41:57 PDT 2006


macdome at opendarwin.org changed:

           What    |Removed                     |Added
                 CC|                            |macdome at opendarwin.org

------- Comment #1 from macdome at opendarwin.org  2006-04-26 18:41 PDT -------
I believe we've fixed all the crashes like this.  I searched for all places in
the parser that was using parentNode().  The normal DOM/RenderTrees should be
safe, because the subtree is fully detached.

A better solution wouuld be to have a function on the parser which coudl be
called at specific times (after a <script> tag for instance) which would walk
down the node stack, checking of they all still had parents, and if not pop all
the way back to one which was still in the tree, setting that one as current.

I chose not to make that change after talking with Maciej at some length.  We
felt that such a change could be very risky for the branch.  We could
reconsider something similar for TOT.  Be aware that one script could modify
another documents tree mid/parse, so there might need to be checks in other
places as well.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list