[Webkit-unassigned] [Bug 8528] Bakefiles (and generated Makefiles) for wx and gdk ports

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8528





------- Comment #8 from kevino at theolliviers.com  2006-04-22 11:10 PDT -------
(In reply to comment #7)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > The bakefiles need to be updated to use WebCore/DerivedSources.make not
> > > make-generated-sources.h
> > > 
> > 
> > Okay you through me with the script name do you know how to get bakefile to
> > generate a rule for a shellscript I could not get this to work myself its a big
> > issues since you can't create generic rules for all using bakefile or at least
> > I did not figure out how
> > 
> > I think what needs to happen is there needs to be a way to add anothere
> > dependency to the all rule that allow us to skip having to run the shell
> > script.
> > If it can't be done then we need to fix this asap in bakefile.
> > 
> > Also the way you almost do it which is what I was trying
> > 
> > 
> >    <exe id="dftables">
> >         <dirname>$(SRCDIR)</dirname>
> >         <sources>$(SRCDIR)/pcre/dftables.c</sources>
> >     </exe>
> > 
> >     <action id="DerivedSources">
> >         <depends>dftables</depends>
> >         <command>./make-generated-sources.sh</command>
> >     </action>
> > 
> > Is a bit verbose that should look more like a tradtional makefile and be done
> > under one toplevel tag.
> > 
> 
> I spoke with Vaclav about why this doesn't work, and what we need to do is add
> an <is-phony/> tag to the DerivedSources target, like so:
> 
>     <action id="DerivedSources">
>         <is-phony/>
>         <depends>dftables</depends>
>         <command>./make-generated-sources.sh</command>
>     </action>
> 
> This makes sure the makefile doesn't check the target for existance and thus
> the step will always run.
> 
> It looks a bit verbose, yes, but then again typically we would have written
> DerivedSources.make in Bakefile and each target would correspond to one file
> that needs to be built/updated, so doing things this way (having a phony target
> that runs a set of commands on numerous files) is a bit of an unusual case.
> Please let me know if this works for you. I'm going to test it out here as well
> and see if we can't remove most of the manual build steps from the process this
> way.
> 

Actually, also, instead of <depends> we need
<objects-depend>DerivedSources</objects-depend> here to make sure the script
runs before any sources are built. With this change in place, I'm able to build
JSCore now simply by running `make -f GNUMakefile`. I'm going to add this to
the wx makefile too, update the docs, and submit a new patch where the only
'setup' step will be running WebKitTools/Scripts/install-unix-extras. 


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.