[Webkit-unassigned] [Bug 6141] DOMCSSPrimitiveValue is always returning values in pixels when using getComputedStyle:

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6141


bdakin at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-                     |bdakin at apple.com
                   |unassigned at opendarwin.org   |
             Status|NEW                         |ASSIGNED
   Attachment #7887|                            |review?
               Flag|                            |




------- Comment #4 from bdakin at apple.com  2006-04-21 16:19 PDT -------
Created an attachment (id=7887)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7887&action=view)
Patch

Here is a patch that fixes the bug. I talked through this design with Hyatt.
Since we use getFloatValue() internally a lot, I created another version that
still just returns m_value.num since that is what the internal callers expect
and since passing in the type was clunky and unnecessary. It is also worth
noting that the given test case does not contain the exact value we return. The
test case expects that we render floating point pixels, but we round to
integers. This causes the expected calculation to be off from the actual
calculation. (It also means that our results, while accurate, do not match
Firefox exactly.) I will upload a more accurate test in a minute.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.