[Webkit-unassigned] [Bug 8507] Compilation fixes for building on gcc 4.0.2, and without precomp headers

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Thu Apr 20 23:58:39 PDT 2006


darin at apple.com changed:

           What    |Removed                     |Added
   Attachment #7865|review?                     |review-
               Flag|                            |

------- Comment #2 from darin at apple.com  2006-04-20 23:58 PDT -------
(From update of attachment 7865)
Looks good. I see three problems:

    1) The include for pthread.h should be !PLATFORM(WIN_OS), not

    2) Assertions.cpp should use <stdio.h>, <stdarg.h>, and <string.h>, not
"stdio.h", etc.

    3) +#elseif defined(__APPLE__)

No such thing as #elseif. It's #elif.

That issue (3) seems serious enough that we should not land it, so r-. But if
you fix those 3 things, then this looks good to go.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list