[Webkit-unassigned] [Bug 6427] <tref> element not implemented

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Tue Apr 18 01:47:10 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=6427


macdome at opendarwin.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7773|review?                     |review-
               Flag|                            |




------- Comment #4 from macdome at opendarwin.org  2006-04-18 01:47 PDT -------
(From update of attachment 7773)
attach() is still the wrong way to do this.  As this won't handle dynamic
updates.  I think this would be "ok" to land as is, but it's better to just fix
it right the first time.

Also, ideally your patch would contain a diff of the test results you've
changed, including possibly a dynamicly updating test to show that you got href
changes working correctly (which is what my previous attach() complaint is
about).

Other than that, this looks great.  Wonderful work as always Rob.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list