[Webkit-unassigned] [Bug 7604] calcAbsoluteHorizontalValues() is being getting passed arguments in the wrong order in calcAbsoluteHorizontal()

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Apr 5 14:59:09 PDT 2006


sam.weinig at gmail.com changed:

           What    |Removed                     |Added
   Attachment #7194|review?(hyatt at apple.com)    |
               Flag|                            |
Attachment #7194 is|0                           |1
           obsolete|                            |
   Attachment #7532|                            |review?(hyatt at apple.com)
               Flag|                            |

------- Comment #7 from sam.weinig at gmail.com  2006-04-05 14:59 PDT -------
Created an attachment (id=7532)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7532&action=view)
patch 3

This is a slightly cleaner version of the patch which removes most of the
repeated FIXME's with 3 big FIXME's at the top and makes a few more slight
optimizations such as not calculating for 'right' and 'bottom' when they are
not needed.  It also includes some changes that were made to the current code
regarding the static distance for 'top' when inside a table row.

This patch compiles fine and passes all the layout tests, but is quite a big
patch and therefore I'm woried that some behavior might have changed from the
origanal as many of the corner cases are not tested in the suite.  I agree with
hyatt in that we should try to stick as closely to the origanal behavior as
possible, but I don't really understand what he is proposing in his comment (if
you could elaborate that would be great), 

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list