[Webkit-unassigned] [Bug 8065] REGRESSION: inline-block elements wrapped in spans lose spaces between them

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8065


hyatt at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7510|                            |review?
               Flag|                            |




------- Comment #6 from hyatt at apple.com  2006-04-04 15:08 PDT -------
Created an attachment (id=7510)
 --> (http://bugzilla.opendarwin.org/attachment.cgi?id=7510&action=view)
Patch that fixes the bug

The bug was in the code that tries to avoid creating RenderTexts if it thinks
they are unnecessary whitespace.  There were two mistakes in the code that
attempted to check for blocks inside inlines.

(1) The parent check just asked if the parent was "inline" and assumed that
meant that it was an inline flow.  This check was incorrectly true for
inline-block parents.

(2) The check for an existing child asked if the child was a RenderBlock.  This
tells you nothing about whether or not the child is inline or not, since
inline-blocks and regular blocks are all RenderBlocks.  In addition it leaves
out block-level replaced elements like images and form controls.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.