[Webkit-unassigned] [Bug 7984] ifdef win32 specific code in GraphicsContextCairo.cpp

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Mon Apr 3 20:37:14 PDT 2006


http://bugzilla.opendarwin.org/show_bug.cgi?id=7984





------- Comment #8 from mike.emmel at gmail.com  2006-04-03 20:37 PDT -------
Okay So we can have PLATFORM(LINUX) &&  PLATFORM(GTK) to specifiy GTK on Linux
For GTK we even have more GDK_DIRECTFB AND GDK_X11 and GDK_WIN32 GDK_OSX  OSX
can for example support 3 of those. Is this okay if I need one of the GTK
variants ?
Similar is true for KDE and WTK. 

At this point the toolkit could provide the variant macro in fact for cairo
this is true I think we have 

CAIRO_HAS_XLIB_SURFACE

Gdk has similar sub variant defines internally.

So I'd so there is not PLATFORM(GDK_DIRECTFB) since this define should be
internal in the toolkit.

Now this mean the Cairo code thats started this bug should actually use

#if CAIRO_HAS_WIN32_SURFACE

Not PLATFORM but the GTK code would be PLATFORM(GTK) ?


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list