[Webkit-unassigned] [Bug 8156] New: FrameMac::submitForm is busted after Vector changes

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8156

           Summary: FrameMac::submitForm is busted after Vector changes
           Product: WebKit
           Version: 420+ (nightly)
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Keywords: Regression
          Severity: normal
          Priority: P1
         Component: HTML Forms
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: macdome at opendarwin.org


I made some changes a while back to how form submission worked, and I busted
FrameMac::submitForm.  Strangely enough, no one has seemed to notice.  However,
WebKit is no longer seeing any form submission data, like it used to.

This call:

    if (!request.doPost()) {
        [_bridge loadURL:request.url().getNSURL()
                referrer:[_bridge referrer] 
                  reload:request.reload
             userGesture:true
                  target:request.frameName
         triggeringEvent:_currentEvent
                    form:_formAboutToBeSubmitted
              formValues:_formValuesAboutToBeSubmitted];

_formAboutToBeSubmitted
and
_formValuesAboutToBeSubmitted
are always nil.

Those values are now held down on Frame, and just need to be converted from
WebCore types into NS types and sent up to WebKit.  It's simple to fix.  I'm
filing this bug so I don't forget.

Maybe somone who knows more about that code path can comment as to why no one
has noticed this being broken.  Maybe WebKit no longer needs to know about form
submission data (unless it's for autofill?)


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.