[Webkit-unassigned] [Bug 8079] REGRESSION: Redraw from page cache does not show visited links

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=8079





------- Comment #6 from ddkilzer at kilzer.net  2006-04-02 20:56 PDT -------
(In reply to comment #5)
> It's really hard to see which of the changes in r13440 caused this! None of
> them seem likely to do so, but if we knew which change it was we could probably
> figure it out.

As it turns out, the historyContains() method in HistoryMac.mm is never called
after r13440 is applied when the browser "Back" button is hit, so my guess is
that some string comparison is no longer causing the links to be re-rendered on
the cached page.  I'm not very familiar with the rendering code in Safari, but
below is the call stack from Safari+WebKit-r13439 when it hits the
historyContains() method.  I will continue looking into this, but I'll be happy
if someone else beats me to it.  :)

#0      0x01ae0938 in WebCore::historyContains at HistoryMac.mm:37
#1      0x019b08a8 in WebCore::checkPseudoState at cssstyleselector.cpp:579
#2      0x019b45b4 in WebCore::CSSStyleSelector::getColorFromPrimitiveValue at
cssstyleselector.cpp:4257
#3      0x019ba094 in WebCore::CSSStyleSelector::applyProperty at
cssstyleselector.cpp:2346
#4      0x019c1c04 in WebCore::CSSStyleSelector::applyDeclarations at
cssstyleselector.cpp:1741
#5      0x019c2fb0 in WebCore::CSSStyleSelector::styleForElement at
cssstyleselector.cpp:788
#6      0x0180af74 in WebCore::Element::recalcStyle at dom_elementimpl.cpp:562
#7      0x0180b2c8 in WebCore::Element::recalcStyle at dom_elementimpl.cpp:599
#8      0x0180b2c8 in WebCore::Element::recalcStyle at dom_elementimpl.cpp:599
#9      0x019279c8 in WebCore::Document::recalcStyle at Document.cpp:836
#10     0x0192d950 in WebCore::Document::updateStyleSelector at
Document.cpp:1756
#11     0x018f9b3c in WebCore::Frame::reparseConfiguration at Frame.cpp:1660
#12     0x01946f54 in -[WebCoreFrameBridge reapplyStylesForDeviceType:] at
WebCoreFrameBridge.mm:868
#13     0x0037ae0c in -[WebHTMLView reapplyStyles] at WebHTMLView.m:2275
#14     0x0037ae80 in -[WebHTMLView
layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:] at
WebHTMLView.m:2290
#15     0x0037b228 in -[WebHTMLView layout] at WebHTMLView.m:2334
#16     0x00361818 in -[WebFrame(WebPrivate) _opened] at WebFrame.m:1028
#17     0x00360690 in -[WebFrame(WebPrivate) _commitProvisionalLoad:] at
WebFrame.m:867
#18     0x003547c4 in -[WebDataSource(WebPrivate) _loadFromPageCache:] at
WebDataSource.m:335
#19     0x0036883c in -[WebFrame(WebPrivate)
_continueLoadRequestAfterNavigationPolicy:formState:] at WebFrame.m:2293
#20     0x003651e8 in -[WebFrame(WebPrivate)
_checkNavigationPolicyForRequest:dataSource:formState:andCall:withSelector:] at
WebFrame.m:1675
#21     0x00368c1c in -[WebFrame(WebPrivate)
_loadDataSource:withLoadType:formState:] at WebFrame.m:2330
#22     0x0036353c in -[WebFrame(WebPrivate) _loadItem:withLoadType:] at
WebFrame.m:1350
#23     0x00363e9c in -[WebFrame(WebPrivate)
_recursiveGoToItem:fromItem:withLoadType:] at WebFrame.m:1469
#24     0x00364074 in -[WebFrame(WebPrivate) _goToItem:withLoadType:] at
WebFrame.m:1489
#25     0x003ab900 in -[WebView(WebPrivate) _goToItem:withLoadType:] at
WebView.m:753
#26     0x003b29b8 in -[WebView goBack] at WebView.m:1873
#27     0x003b613c in -[WebView(WebIBActions) goBack:] at WebView.m:2425
[...]


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.