[Webkit-unassigned] [Bug 6306] New: Deploy PassRefPtr wherever "return new" is found

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Fri Dec 30 14:18:14 PST 2005


           Summary: Deploy PassRefPtr wherever "return new" is found
           Product: WebKit
           Version: 412+
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P4
         Component: WebKit Misc.
        AssignedTo: webkit-unassigned at opendarwin.org
        ReportedBy: macdome at opendarwin.org

Deploy PassRefPtr wherever "return new" is found

This is an easy starter bug for someone wanting to take a tour of large amounts of code.

Any time you see "return new" in the code, it's probabably a case wher that function should be 
returning a PassRefPtr instead of a raw pointer.  Why?  Mostly to prevent leaks.  This can also improve 
performance, as PassRefPtr can avoid any Ref churn (it's ref'd once during the return and the doesn't 
need to be ref'd again until passed into some other object and assigned to a RefPtr).

There are 435 instances in my copy of WebCore.  So these are changes which should be done a couple 
files at a time.  Every change of a function from raw pointer to PassRefPtr will likely require changing all 
the callsites as well.

I'm slowly getting to these.  But others looking to help, is good too.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list