[Webkit-unassigned] [Bug 6259] Handle negative, FP numbers with non-10 radix in toString

[bugzilla-daemon at opendarwin.org]

http://bugzilla.opendarwin.org/show_bug.cgi?id=6259


mjs at apple.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #5309|review?                     |review+
               Flag|                            |




------- Additional Comments From mjs at apple.com  2005-12-28 21:23 -------
(From update of attachment 5309)
I'll grant review because I think  it's better to have this change than not.
However:

> +      const double eps = 0.001; // TODO: guessed. base on radix ?

That seems like a pretty high value for epsilon.

> int(d)
> double(radix)

(in various places) - it would be better to avoid this cast syntax for numbers,
I think. In some cases I think it is unnecesary, in other cases a normal
c-style cast or assigning first to a variable of the appropriate type would be
better.

I think these improvements can be made in a separate pass though.


-- 
Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.