[Webkit-unassigned] [Bug 6259] Handle negative, FP numbers with non-10 radix in toString

bugzilla-daemon at opendarwin.org bugzilla-daemon at opendarwin.org
Wed Dec 28 21:23:39 PST 2005


mjs at apple.com changed:

           What    |Removed                     |Added
   Attachment #5309|review?                     |review+
               Flag|                            |

------- Additional Comments From mjs at apple.com  2005-12-28 21:23 -------
(From update of attachment 5309)
I'll grant review because I think  it's better to have this change than not.

> +      const double eps = 0.001; // TODO: guessed. base on radix ?

That seems like a pretty high value for epsilon.

> int(d)
> double(radix)

(in various places) - it would be better to avoid this cast syntax for numbers,
I think. In some cases I think it is unnecesary, in other cases a normal
c-style cast or assigning first to a variable of the appropriate type would be

I think these improvements can be made in a separate pass though.

Configure bugmail: http://bugzilla.opendarwin.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list