[webkit-reviews] review granted: [Bug 293183] Allow renderers to get destroyed async after detach : [Attachment 475320] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 293183: Allow renderers to get destroyed async after detach
https://bugs.webkit.org/show_bug.cgi?id=293183

Attachment 475320: Patch

https://bugs.webkit.org/attachment.cgi?id=475320




--- Comment #11 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 475320
  --> https://bugs.webkit.org/attachment.cgi?id=475320
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=475320&action=review

> Source/WebCore/page/LocalFrameViewLayoutContext.cpp:756
> +static constexpr int maximumNumberOfDetachedRenderers = 5000;

could be in the function scope

> Source/WebCore/page/LocalFrameViewLayoutContext.cpp:772
> +	   if (m_renderers.size() == maximumNumberOfDetachedRenderers)
> +	       return false;
> +	   // FIXME: Cleanup RenderWidget's destruction process (ref vs. delete
this. see RenderObject::destroy)
> +	   return !is<RenderWidget>(detachedRenderer);
> +    };
> +    if (isEligibleForDelayedDeletation()) {
> +	   m_renderers.append(detachedRenderer.release());
> +	   return true;
> +    }
> +    return false;

or I guess we could fully delete the contents of the previous list and start
building a new one at this point