[webkit-reviews] review granted: [Bug 286593] Emoji is cut off when typing on the same line as text : [Attachment 474026] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 286593: Emoji is cut off when typing on the same line as text
https://bugs.webkit.org/show_bug.cgi?id=286593

Attachment 474026: Patch

https://bugs.webkit.org/attachment.cgi?id=474026




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 474026
  --> https://bugs.webkit.org/attachment.cgi?id=474026
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=474026&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:233
> +    if (style.fontCascade().codePath(TextRun { textContent }) !=
FontCascade::CodePath::Complex) {

We have already computed and cached the path for InlineTextBox. Callers have
InlineTextBox so we could pass the path and avoid recomputing it.