[webkit-reviews] review granted: [Bug 283532] [Cleanup][content-visibility] shouldApply*Containment functions don't need to be on RenderElement : [Attachment 473323] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 283532: [Cleanup][content-visibility] shouldApply*Containment functions
don't need to be on RenderElement
https://bugs.webkit.org/show_bug.cgi?id=283532

Attachment 473323: Patch

https://bugs.webkit.org/attachment.cgi?id=473323




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 473323
  --> https://bugs.webkit.org/attachment.cgi?id=473323
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=473323&action=review

> Source/WebCore/rendering/style/RenderStyle.h:2423
> +inline bool shouldApplyLayoutContainment(const RenderStyle&, const
Element&);
> +inline bool shouldApplySizeContainment(const RenderStyle&, const Element&);
> +inline bool shouldApplyInlineSizeContainment(const RenderStyle&, const
Element&);
> +inline bool shouldApplyStyleContainment(const RenderStyle&, const Element&);
> +inline bool shouldApplyPaintContainment(const RenderStyle&, const Element&);
> +inline bool isSkippedContentRoot(const RenderStyle&, const Element&);

not sure this stuff needs to be inline