[webkit-reviews] review granted: [Bug 282587] [TextBoxPainter] Let's pass in a TextBox to TextBoxPainter : [Attachment 473140] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 5 00:31:08 PST 2024


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 282587: [TextBoxPainter] Let's pass in a TextBox to TextBoxPainter
https://bugs.webkit.org/show_bug.cgi?id=282587

Attachment 473140: Patch

https://bugs.webkit.org/attachment.cgi?id=473140&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 473140
  --> https://bugs.webkit.org/attachment.cgi?id=473140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=473140&action=review

> Source/WebCore/rendering/TextBoxPainter.h:95
> -    // FIXME: We could just talk to the display box directly.
> -    const InlineIterator::BoxModernPath m_textBox;
> +    const InlineIterator::TextBox& m_textBox;

The reason we switch to templating instead of using the iterator (in bug
240416) was performance. The FIXME suggests going to the other direction (less
abstract).


More information about the webkit-reviews mailing list