[webkit-reviews] review granted: [Bug 282422] [shape-outside] Inline content incorrectly positioned around RTL and/or vertical shape-outside floats : [Attachment 473101] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 282422: [shape-outside] Inline content incorrectly positioned around RTL
and/or vertical shape-outside floats
https://bugs.webkit.org/show_bug.cgi?id=282422

Attachment 473101: Patch

https://bugs.webkit.org/attachment.cgi?id=473101&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 473101
  --> https://bugs.webkit.org/attachment.cgi?id=473101
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=473101&action=review

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:169
> +	       if (isHorizontalWritingMode && writingMode.isBidiLTR())
> +		   return;

This seem unnecessary, the same tests are done later again

> Source/WebCore/rendering/shapes/ShapeOutsideInfo.cpp:179
> +	       if (!writingMode.isBidiLTR()) {

isBidiRTL()?