[webkit-reviews] review granted: [Bug 274108] [Remote Inspection] AX: Add screen reader support for targeted elements : [Attachment 471394] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted  review:
Bug 274108: [Remote Inspection] AX: Add screen reader support for targeted
elements
https://bugs.webkit.org/show_bug.cgi?id=274108

Attachment 471394: Patch

https://bugs.webkit.org/attachment.cgi?id=471394&action=review




--- Comment #4 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 471394
  --> https://bugs.webkit.org/attachment.cgi?id=471394
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471394&action=review

> Source/WebCore/page/text-extraction/TextExtraction.cpp:469
> +static void extractRenderedText(Vector<StringsAndBlockOffset>&
stringsAndOffsets, ContainerNode& node, BlockFlowDirection direction, bool
shouldIncludeGeometry)

Nit - maybe make this an `enum class : bool`?