[webkit-reviews] review granted: [Bug 273968] AX: AXObjectCache::postPlatformNotification should take an AccessibilityObject not an AXCoreObject. : [Attachment 471346] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 273968: AX: AXObjectCache::postPlatformNotification should take an
AccessibilityObject not an AXCoreObject.
https://bugs.webkit.org/show_bug.cgi?id=273968

Attachment 471346: Patch

https://bugs.webkit.org/attachment.cgi?id=471346&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 471346
  --> https://bugs.webkit.org/attachment.cgi?id=471346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471346&action=review

> Source/WebCore/accessibility/AXObjectCache.h:598
> +    void postPlatformNotification(const AccessibilityObject&,
AXNotification);

How about having this take a reference and not a const reference? Could avoid
the const_cast and I think it makes logical sense either way.