[webkit-reviews] review granted: [Bug 273898] [Cleanup] Remove RenderBox::hasOverridingLogicalHeightLength : [Attachment 471325] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 273898: [Cleanup] Remove RenderBox::hasOverridingLogicalHeightLength
https://bugs.webkit.org/show_bug.cgi?id=273898

Attachment 471325: Patch

https://bugs.webkit.org/attachment.cgi?id=471325&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 471325
  --> https://bugs.webkit.org/attachment.cgi?id=471325
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471325&action=review

> Source/WebCore/rendering/RenderBox.cpp:1414
> +    return iterator != gOverridingLogicalHeightLengthMap->end() ?
std::make_optional(iterator->value) : std::nullopt;

Use getOptional()