[webkit-reviews] review granted: [Bug 270616] AX: VoiceOver doesn't read characters when user presses left / right arrows in Monaco code editor : [Attachment 470251] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 8 16:02:34 PST 2024


Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 270616: AX: VoiceOver doesn't read characters when user presses left /
right arrows in Monaco code editor
https://bugs.webkit.org/show_bug.cgi?id=270616

Attachment 470251: Patch

https://bugs.webkit.org/attachment.cgi?id=470251&action=review




--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 470251
  --> https://bugs.webkit.org/attachment.cgi?id=470251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470251&action=review

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:511
> +    AXTextStateChangeIntent intent = originalIntent;
> +
> +    if (!object.isTextControl() && !object.editableAncestor())
> +	   return originalIntent;

AXTextStateChangeIntent intent = originalIntent;

This copy is unnecessary if condition !object.isTextControl() &&
!object.editableAncestor() is true. Does it work to move it below the
if-statement?

> LayoutTests/accessibility/mac/custom-text-editor.html:40
> +	   if (dir == AXTextSelectionDirectionNext) {
> +	       str += " next";
> +	   } else if (dir == AXTextSelectionDirectionPrevious) {
> +	       str += " previous";
> +	   } else if (dir == AXTextSelectionDirectionDiscontiguous) {
> +	       str += " discontiguous";
> +	   }

I think these braces are unnecessary too, but not a huge deal.


More information about the webkit-reviews mailing list