[webkit-reviews] review granted: [Bug 270535] AX: AXPropertyName::{ColumnIndex, RowIndex} are not updated on the isolated tree : [Attachment 470198] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 270535: AX: AXPropertyName::{ColumnIndex, RowIndex} are not updated on the
isolated tree
https://bugs.webkit.org/show_bug.cgi?id=270535

Attachment 470198: Patch

https://bugs.webkit.org/attachment.cgi?id=470198&action=review




--- Comment #9 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 470198
  --> https://bugs.webkit.org/attachment.cgi?id=470198
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470198&action=review

> LayoutTests/accessibility/dynamic-table-row-column-indices.html:30
> +    for (let i = 0; i < table.rowCount; i++) {
> +	   result += `Row Index [${i}]:
${table.rowAtIndex(i).indexInTable()}\n`;
> +    }   
> +
> +    const columns = table.columns();
> +    for (let i = 0; i < table.columnCount; i++) {
> +	   result += `Column Index [${i}]: ${columns[i].indexInTable()}\n`;
> +    }   

The curly braces aren't necessary here, but not a huge deal.