[webkit-reviews] review granted: [Bug 270499] AX: NULL attributed string returned for text markers that contain unconnected nodes : [Attachment 470172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 4 19:55:12 PST 2024


Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 270499: AX: NULL attributed string returned for text markers that contain
unconnected nodes
https://bugs.webkit.org/show_bug.cgi?id=270499

Attachment 470172: Patch

https://bugs.webkit.org/attachment.cgi?id=470172&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 470172
  --> https://bugs.webkit.org/attachment.cgi?id=470172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470172&action=review

> LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:6
> +<input type="text" id="input1" value="Hello">

Can this just be id="input"? IMO, "input1" implies there's an input2 / input3 /
etc.

> LayoutTests/accessibility/mac/selected-text-range-unconnected-object.html:16
> +    let startMarker =
root.startTextMarkerForTextMarkerRange(textMarkerRange);
> +    let endMarker = root.endTextMarkerForTextMarkerRange(textMarkerRange);
> +
> +    let startElement = root.accessibilityElementForTextMarker(startMarker);
> +    let endElement = root.accessibilityElementForTextMarker(endMarker);

Can these be const?


More information about the webkit-reviews mailing list