[webkit-reviews] review granted: [Bug 275153] Limit the number of repaint candidates after simplified layout : [Attachment 471610] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 275153: Limit the number of repaint candidates after simplified layout
https://bugs.webkit.org/show_bug.cgi?id=275153

Attachment 471610: Patch

https://bugs.webkit.org/attachment.cgi?id=471610&action=review




--- Comment #6 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 471610
  --> https://bugs.webkit.org/attachment.cgi?id=471610
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471610&action=review

> Source/WebCore/page/LocalFrameViewLayoutContext.h:190
> +    unsigned m_layoutIdentifier : 11 { 0 };

Let's use a type for LayoutIdentifier

> Source/WebCore/rendering/RenderElement.h:409
> +    unsigned m_layoutIdentifier : 11 { 0 };

Maybe we should just eat up 16 or 32 bits (shuffling things around if
necessary).

> Source/WebCore/rendering/RenderLayer.cpp:1025
> +	       return renderer().layoutIdentifier() ==
renderer().view().frameView().layoutContext().layoutIdentifier();

Think about putting this in a helper on RenderElement.