[webkit-reviews] review granted: [Bug 274981] REGRESSION (279348 at main): Flickr photos flash at wrong offset when paging through album : [Attachment 471560] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 274981: REGRESSION (279348 at main): Flickr photos flash at wrong offset when
paging through album
https://bugs.webkit.org/show_bug.cgi?id=274981

Attachment 471560: Patch

https://bugs.webkit.org/attachment.cgi?id=471560&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 471560
  --> https://bugs.webkit.org/attachment.cgi?id=471560
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471560&action=review

> Source/WebCore/rendering/RenderBlock.cpp:823
> -    return (posChildNeedsLayout() || needsSimplifiedNormalFlowLayout()) &&
!normalChildNeedsLayout() && !selfNeedsLayout();
> +    return (posChildNeedsLayout() || needsSimplifiedNormalFlowLayout()) &&
!normalChildNeedsLayout() && !outOfFlowChildNeedsStaticPositionLayout() &&
!selfNeedsLayout();

would be nice to split this up to read better

> Source/WebCore/rendering/RenderElement.cpp:1210
> +    // FIXME: Currently this dirty bit has a very limite useage but should
be expanded to

"limited usage"