[webkit-reviews] review granted: [Bug 267768] AX: The AccessibilityText property of labeled objects is not updated when the label is removed. : [Attachment 469459] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 19 11:29:38 PST 2024


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 267768: AX: The AccessibilityText property of labeled objects is not
updated when the label is removed.
https://bugs.webkit.org/show_bug.cgi?id=267768

Attachment 469459: Patch

https://bugs.webkit.org/attachment.cgi?id=469459&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 469459
  --> https://bugs.webkit.org/attachment.cgi?id=469459
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469459&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:1079
> -    removeRelations(axID);
> -
>  #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
>      if (auto tree = AXIsolatedTree::treeForPageID(m_pageID))
>	   tree->removeNode(*object);
>  #endif
>  
> +    removeRelations(axID);

TW: Just curious, why move this? Just for organization, or is there some
logical difference?


More information about the webkit-reviews mailing list