[webkit-reviews] review granted: [Bug 267599] AX: AXObjectCache::updateIsolatedTree may cause the update of dependent properties for the same object multiple times unnecessarily. : [Attachment 469419] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 16 11:51:26 PST 2024


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 267599: AX: AXObjectCache::updateIsolatedTree may cause the update of
dependent properties for the same object multiple times unnecessarily.
https://bugs.webkit.org/show_bug.cgi?id=267599

Attachment 469419: Patch

https://bugs.webkit.org/attachment.cgi?id=469419&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 469419
  --> https://bugs.webkit.org/attachment.cgi?id=469419
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469419&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:4180
> +	       updatedObjects.set(axObject->objectID(), updatedFields);

Not sure how expensive OptionSet copies are, but maybe WTFMove(updatedFields)
would be more efficient?

> Source/WebCore/accessibility/AXObjectCache.cpp:4188
> +	       updatedObjects.set(axObject->objectID(), updatedFields);

WTFMove(updatedFields)?

> Source/WebCore/accessibility/AXObjectCache.cpp:4196
> +	       updatedObjects.set(axObject->objectID(), updatedFields);

WTFMove(updatedFields)?


More information about the webkit-reviews mailing list