[webkit-reviews] review granted: [Bug 270276] AX: VoiceOver reads erroneous value for datetime-local input elements. : [Attachment 470090] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 270276: AX: VoiceOver reads erroneous value for datetime-local input
elements.
https://bugs.webkit.org/show_bug.cgi?id=270276

Attachment 470090: Patch

https://bugs.webkit.org/attachment.cgi?id=470090&action=review




--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 470090
  --> https://bugs.webkit.org/attachment.cgi?id=470090
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470090&action=review

> Tools/WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:921
> +    auto description = descriptionOfValue(value.get());
> +    if (description)
> +	   return concatenateAttributeAndValue(@"AXDateValue",
description.get());

Can this be:

if (auto description = descriptionOfValue(value.get()))
    return concatenateAttributeAndValue(@"AXDateValue", description.get());