[webkit-reviews] review granted: [Bug 269341] "Look Up" popover is not attached to highlighted words at the end of a line on New York Times : [Attachment 469904] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted  review:
Bug 269341: "Look Up" popover is not attached to highlighted words at the end
of a line on New York Times
https://bugs.webkit.org/show_bug.cgi?id=269341

Attachment 469904: Patch

https://bugs.webkit.org/attachment.cgi?id=469904&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 469904
  --> https://bugs.webkit.org/attachment.cgi?id=469904
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=469904&action=review

> Source/WebCore/editing/TextIterator.cpp:642
> +	   auto hasPreviousCollapsedWhitespace =
m_lastTextNodeEndedWithCollapsedSpace || (m_textRun == firstTextRun &&
textRunStart == runStart && runStart);

Maybe hasPrecedingCollapsedWhitespace?