[webkit-reviews] review granted: [Bug 273248] AX: Implement off-main-thread support for AXTextMarkerRangeForLineAttribute : [Attachment 471135] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 273248: AX: Implement off-main-thread support for
AXTextMarkerRangeForLineAttribute
https://bugs.webkit.org/show_bug.cgi?id=273248

Attachment 471135: Patch

https://bugs.webkit.org/attachment.cgi?id=471135&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 471135
  --> https://bugs.webkit.org/attachment.cgi?id=471135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471135&action=review

> Source/WebCore/accessibility/AXTextMarker.h:199
> +    AXTextMarkerRange markerRangeForLine(unsigned lineIndex) const;

markerRangeForLineIndex(unsigned)

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:2351
> +    else if ([parameter isKindOfClass:[NSValue class]] &&
!strcmp([(NSValue*)parameter objCType], @encode(NSRange)))

NSValue *

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:3797
> +    if (AXObjectCache::clientIsInTestMode()) {

UNLIKELY()