[webkit-reviews] review granted: [Bug 273284] AX: Re-enable accessibility/ios-simulator/inline-prediction-attributed-string test : [Attachment 471151] Patch

[bugzilla-daemon at webkit.org]

Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 273284: AX: Re-enable
accessibility/ios-simulator/inline-prediction-attributed-string test
https://bugs.webkit.org/show_bug.cgi?id=273284

Attachment 471151: Patch

https://bugs.webkit.org/attachment.cgi?id=471151&action=review




--- Comment #5 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 471151
  --> https://bugs.webkit.org/attachment.cgi?id=471151
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=471151&action=review

Looks good minus maybe one missing null check.

> Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:654
> +	   auto* annotationDataArray = WebKit::toImpl(annotationData);
> +	   for (auto dictionary :
annotationDataArray->elementsOfType<API::Dictionary>()) {

Does annotationDataArray need a null-check? Would it be possible to do this?

if (auto* annotationDataArray = WebKit::toImpl(annotationData)) {
    ...
}