[webkit-reviews] review granted: [Bug 272803] AX: Move objectsForIDs back off of the main thread : [Attachment 470967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 17 12:23:43 PDT 2024

Tyler Wilcock <tyler_w at apple.com> has granted  review:
Bug 272803: AX: Move objectsForIDs back off of the main thread

Attachment 470967: Patch


--- Comment #6 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 470967
  --> https://bugs.webkit.org/attachment.cgi?id=470967

View in context: https://bugs.webkit.org/attachment.cgi?id=470967&action=review

Looks good to me, but maybe we can wait for Andres to take a pass too since
he's the expert in the relations code.

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:504
>      if (object.accessibilityIsIgnored()) {
> -	   if (auto tree = AXIsolatedTree::treeForPageID(pageID))
> -	       tree->addUnconnectedNode(object);
> +	   cache.deferAddUnconnectedNode(object);
>      }

Curly-braces can be removed here since this is now only one line

More information about the webkit-reviews mailing list