[webkit-reviews] review granted: [Bug 272279] AX: Use more reference types in accessibility code when values are known to be non-null : [Attachment 470790] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 272279: AX: Use more reference types in accessibility code when values are
known to be non-null
https://bugs.webkit.org/show_bug.cgi?id=272279

Attachment 470790: Patch

https://bugs.webkit.org/attachment.cgi?id=470790&action=review




--- Comment #6 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 470790
  --> https://bugs.webkit.org/attachment.cgi?id=470790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=470790&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:154
> +static bool rendererIsValid(Node& node)

Feels like name should be

NodeRendererIsValid

> Source/WebCore/accessibility/AXObjectCache.cpp:3136
>      Node* domNode = &node;

Do we still
Need a ptr here or can we use a reference in the method

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1743
>      for (RefPtr e = position.anchorElementAncestor(); e && e !=
rootEditableElement; e = e->parentElement()) {

Do we have to use e for a variable name?