[webkit-reviews] review granted: [Bug 261900] [IFC][Ruby] Implement overhangForAnnotationBefore/overhangForAnnotationAfter : [Attachment 467817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Sep 22 01:48:15 PDT 2023


Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 261900: [IFC][Ruby] Implement
overhangForAnnotationBefore/overhangForAnnotationAfter
https://bugs.webkit.org/show_bug.cgi?id=261900

Attachment 467817: Patch

https://bugs.webkit.org/attachment.cgi?id=467817&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467817
  --> https://bugs.webkit.org/attachment.cgi?id=467817
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467817&action=review

>
Source/WebCore/layout/formattingContexts/inline/ruby/RubyFormattingContext.cpp:
157
> +    if (!annotationBox || rubyBaseContentEndIndex == boxes.size() -1)

space missing after -


More information about the webkit-reviews mailing list