[webkit-reviews] review granted: [Bug 261838] AX: AccessibilityObject::listMarkerTextForNodeAndPosition forces resolution of Position to VisiblePosition even when it's not used : [Attachment 467794] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 261838: AX: AccessibilityObject::listMarkerTextForNodeAndPosition forces
resolution of Position to VisiblePosition even when it's not used
https://bugs.webkit.org/show_bug.cgi?id=261838

Attachment 467794: Patch

https://bugs.webkit.org/attachment.cgi?id=467794&action=review




--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 467794
  --> https://bugs.webkit.org/attachment.cgi?id=467794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467794&action=review

> Source/WebCore/accessibility/AccessibilityObject.cpp:1704
> +    return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) :
StringView();

does this work

return listItem ? listMarkerText(*listItem, WTFMove(startPosition)) : { };