[webkit-reviews] review granted: [Bug 261742] AX: Add AXCorObject.cpp and move methods implementation from AccessibilityObjectInterface.h. : [Attachment 467790] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Sep 20 13:05:23 PDT 2023


Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 261742: AX: Add AXCorObject.cpp and move methods implementation from
AccessibilityObjectInterface.h.
https://bugs.webkit.org/show_bug.cgi?id=261742

Attachment 467790: Patch

https://bugs.webkit.org/attachment.cgi?id=467790&action=review




--- Comment #5 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467790
  --> https://bugs.webkit.org/attachment.cgi?id=467790
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467790&action=review

> Source/WebCore/accessibility/AXCoreObject.cpp:119
> +	   // These roles are containers whose children support aria-selected:

Seems like this comment got indented an extra level as part of the move.

> Source/WebCore/accessibility/AXCoreObject.cpp:128
> +	   // These roles are containers whose children are treated as selected
by assistive
> +	   // technologies. We can get the "selected" item via
aria-activedescendant or the
> +	   // focused element.

Seems like this comment got indented an extra level as part of the move.


More information about the webkit-reviews mailing list