[webkit-reviews] review granted: [Bug 261646] AX: Computed role of role="form" and role="region" elements does not dynamically update when label changes : [Attachment 467722] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted  review:
Bug 261646: AX: Computed role of role="form" and role="region" elements does
not dynamically update when label changes
https://bugs.webkit.org/show_bug.cgi?id=261646

Attachment 467722: Patch

https://bugs.webkit.org/attachment.cgi?id=467722&action=review




--- Comment #4 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 467722
  --> https://bugs.webkit.org/attachment.cgi?id=467722
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467722&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:2459
> +	   RefPtr axObject = getOrCreate(element);

do we need to create an object here, or is just getting an existing one
sufficient, since other creation methods will get the right value?