[webkit-reviews] review granted: [Bug 261428] AX ITM: Not necessary to cache IsFocused in isolated objects. : [Attachment 467647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 11 16:16:18 PDT 2023

Tyler Wilcock <tyler_w at apple.com> has granted Andres Gonzalez
<andresg_22 at apple.com>'s request for review:
Bug 261428: AX ITM: Not necessary to cache IsFocused in isolated objects.

Attachment 467647: Patch


--- Comment #3 from Tyler Wilcock <tyler_w at apple.com> ---
Comment on attachment 467647
  --> https://bugs.webkit.org/attachment.cgi?id=467647

View in context: https://bugs.webkit.org/attachment.cgi?id=467647&action=review

> +Instead of caching this property and updating it, this patch changes the
implementation of AXIsolatedObject::isFocused() to use the tree's focused
object ID. this guaranties consistency between the methods isFocuse() and
focusedUIElement, i.e., isFocused() will return true if and only if the object
is the unique focus.

> this guaranties
this should probably be capitalized, and guaranties looks like a typo.
isFocuse() is another likely typo.

More information about the webkit-reviews mailing list