[webkit-reviews] review granted: [Bug 222315] Enable WASM on Windows : [Attachment 467540] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Sep 4 14:30:25 PDT 2023
Darin Adler <darin at apple.com> has granted Ian Grunert <ian.grunert at gmail.com>'s
request for review:
Bug 222315: Enable WASM on Windows
https://bugs.webkit.org/show_bug.cgi?id=222315
Attachment 467540: Patch
https://bugs.webkit.org/attachment.cgi?id=467540&action=review
--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 467540
--> https://bugs.webkit.org/attachment.cgi?id=467540
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=467540&action=review
>> Source/JavaScriptCore/wasm/WasmSlowPaths.cpp:764
>> + WASM_RETURN_TWO(bitwise_cast<void*>(static_cast<uintptr_t>(1L)),
bitwise_cast<void*>(static_cast<uintptr_t>(Wasm::ExceptionType::OutOfBoundsTabl
eAccess)));
>
> This can just be 1 instead of 1L now that we are casting it to an integer
type.
This can just be 1 instead of 1L now that we are casting it to an integer type.
More information about the webkit-reviews
mailing list