[webkit-reviews] review granted: [Bug 261030] [IFC][line-clamp] Add support for "more info" type of trailing link handling : [Attachment 467521] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted  review:
Bug 261030: [IFC][line-clamp] Add support for "more info" type of trailing link
handling
https://bugs.webkit.org/show_bug.cgi?id=261030

Attachment 467521: Patch

https://bugs.webkit.org/attachment.cgi?id=467521&action=review




--- Comment #5 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 467521
  --> https://bugs.webkit.org/attachment.cgi?id=467521
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=467521&action=review

>
Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayLineBuilde
r.cpp:414
> +    // This is link-box type of line clamping where we check if the inline
content ends in a link
> +    // and move such link content next to the clamped line's trailing
ellispsis.
> +    //
> +    // first line
> +    // second line is clamped... more info
> +    //
> +    // where "more info" is a link and it comes from the end of the inline
content (normally invisible due to block direction clamping)
> +    // This is only to match legacy line clamping behavior (and not a
block-ellispsis: <string> implementation)
> +    // It supports horizontal, left-to-right content only where the link
inline box has (non-split) text content and when
> +    // the link content ('more info') fits the clamped line.

It would be nice to give some background about what this is for and why this is
still needed (and also that it is triggered by -webkit-line-clamp).